Bash executor should not tolerate non-zero exit codes by default #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: From github issue facebookincubator#210 facebookincubator#210 > All inline TTPs will have set -e by default. If a user wants to not run a step with that, they can add set +e to their TTP. Differential Revision: D50892103
inesusvet
requested review from
l50,
d3sch41n,
cedowens and
godlovepenn
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D50892103 |
|
This pull request has been merged in 486ec6a. |
inesusvet
added a commit
to inesusvet/TTPForge
that referenced
this pull request
Oct 29, 2024
Summary: Set ErrorActionPreference variable as first thing when executing the powershell TTPs Resolves facebookincubator#517 Brings parity with bash fail-fast logic introduced in facebookincubator#406 Differential Revision: D65080213
inesusvet
added a commit
to inesusvet/TTPForge
that referenced
this pull request
Oct 29, 2024
Summary: Set ErrorActionPreference variable as first thing when executing the powershell TTPs Resolves facebookincubator#517 Brings parity with bash fail-fast logic introduced in facebookincubator#406 Differential Revision: D65080213
inesusvet
added a commit
to inesusvet/TTPForge
that referenced
this pull request
Oct 29, 2024
Summary: Set ErrorActionPreference variable as first thing when executing the powershell TTPs Resolves facebookincubator#517 Brings parity with bash fail-fast logic introduced in facebookincubator#406 Differential Revision: D65080213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
From github issue #210
#210
Differential Revision: D50892103