Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving tutorials into tests and organizing tests #1178

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Moving tutorials into tests and organizing tests #1178

merged 1 commit into from
Dec 6, 2024

Conversation

sumane81
Copy link
Contributor

@sumane81 sumane81 commented Dec 6, 2024

Project Robyn

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: API change with a documentation update
  • test: Additional test coverage
  • reformat: Code cleanup, recoding or reformating code

How Has This Been Tested?

  • Fork the repo and create your branch from master (latest dev version).
  • If you've changed docuemntation, run devtools::document(). Should update .Rd files.
  • Ensure all tests pass, run devtools::check(). Should have no notes, no warning, no errors.
  • Make sure your code lints.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
alxlyj
alxlyj approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@alxlyj alxlyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sumane81 sumane81 merged commit 64a1f25 into robynpy_release Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxlyj alxlyj alxlyj approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumane81 @alxlyj @facebook-github-bot