Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 4 new graphs to Pareto Optimizer + bug fixes #1159

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

dhavalpatel624624
Copy link
Contributor

This PR addresses the addition of some missing plots for robyn_plots

New 4 graphs:
image
Screenshot 2024-11-21 at 11 26 48 PM

Updated the notebooks to address the changes.
Added code in feature_engineering that was not setting the default value for factor_variables if it wasn't passed in

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2024
Copy link
Contributor

@alxlyj alxlyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dhavalpatel624624 dhavalpatel624624 merged commit 209513b into robynpy_release Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants