Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-dom to peer dependencies #2312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alirezamirian
Copy link

react-dom is an optional peer dependency which means it should be listed in peerDependencies.

An example of an issue it can cause is this error when used with Module Federation:

No required version specified and unable to automatically determine one. Unable to find required version for "react-dom" in description file (/Users/be5806/workspace/wccj/channel-devkit-playground/channels/channel-default/node_modules/recoil/package.json). It need to be in dependencies, devDependencies or peerDependencies.

react-native should also be added but I didn't know what the version requirement is.

react-dom is an optional peer dependency which means it should be listed in peerDependencies.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants