Optimize async selector cache lookups #1736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35608162 |
Summary: Pull Request resolved: facebookexperimental#1736 Optimize looking up existing executions of pending async selectors. Instead of having to transitively evaluate all dependencies we can cache if a particular state version has been checked as valid for the current evaluation. This also includes a fix for the following condition: * An async selector discovers a new dependency but doesn't resolve yet. That dependency is based on the state when the evaluation stated (so each evaluation always has a consistent picture of state) * However, when the new dependency was discovered either the current store has a new version of state or another store does. This new version has a new value for the dependency which may cause the selector to evaluate differently. Differential Revision: D35608162 fbshipit-source-id: c9f66635116c063ea2311d4cc52502840a4f47e9
|
This pull request was exported from Phabricator. Differential Revision: D35608162 |
drarmstr
force-pushed
the
export-D35608162
branch
from
907bb47
to
0e491b8
Compare
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1736 Optimize looking up existing executions of pending async selectors. Instead of having to transitively evaluate all dependencies we can cache if a particular state version has been checked as valid for the current evaluation. This also includes a fix for the following condition: * An async selector discovers a new dependency but doesn't resolve yet. That dependency is based on the state when the evaluation stated (so each evaluation always has a consistent picture of state) * However, when the new dependency was discovered either the current store has a new version of state or another store does. This new version has a new value for the dependency which may cause the selector to evaluate differently. Reviewed By: yukonfb Differential Revision: D35608162 fbshipit-source-id: 5141d41816f4c6cc2a8073d34d8b66cd48565e5f
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1736 Optimize looking up existing executions of pending async selectors. Instead of having to transitively evaluate all dependencies we can cache if a particular state version has been checked as valid for the current evaluation. This also includes a fix for the following condition: * An async selector discovers a new dependency but doesn't resolve yet. That dependency is based on the state when the evaluation stated (so each evaluation always has a consistent picture of state) * However, when the new dependency was discovered either the current store has a new version of state or another store does. This new version has a new value for the dependency which may cause the selector to evaluate differently. Reviewed By: yukonfb Differential Revision: D35608162 fbshipit-source-id: 5141d41816f4c6cc2a8073d34d8b66cd48565e5f
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1736 Optimize looking up existing executions of pending async selectors. Instead of having to transitively evaluate all dependencies we can cache if a particular state version has been checked as valid for the current evaluation. This also includes a fix for the following condition: * An async selector discovers a new dependency but doesn't resolve yet. That dependency is based on the state when the evaluation stated (so each evaluation always has a consistent picture of state) * However, when the new dependency was discovered either the current store has a new version of state or another store does. This new version has a new value for the dependency which may cause the selector to evaluate differently. Reviewed By: yukonfb Differential Revision: D35608162 fbshipit-source-id: 5141d41816f4c6cc2a8073d34d8b66cd48565e5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Optimize looking up existing executions of pending async selectors. Instead of having to transitively evaluate all dependencies we can cache if a particular state version has been checked as valid for the current evaluation.
This also includes a fix for the following condition:
Differential Revision: D35608162