useRecoilCallback() snapshot gets the latest state #1610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34236485 |
|
@drarmstr |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Feb 15, 2022
…tal#1610) Summary: Pull Request resolved: facebookexperimental#1610 NOTE: This is a breaking change, but the previous approach had a bug. Previously, `useRecoilCallback()` would attempt to provide a `Snapshot` based on the state that was currently rendered. However, there were some bugs where this was not the case. For example, a callback called from an effect handler may or may not have had the latest rendered state based on the timing of the setter. The new approach `useRecoilCallback()` will always try to get a snapshot with the latest state. This should also be more intuitive for users. Addresses facebookexperimental#1604 Reviewed By: habond Differential Revision: D34236485 fbshipit-source-id: 8a41e15556900dfb41628b2d77ea23409166f50a
|
This pull request was exported from Phabricator. Differential Revision: D34236485 |
drarmstr
force-pushed
the
export-D34236485
branch
from
0346702
to
9376272
Compare
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Feb 15, 2022
…tal#1610) Summary: Pull Request resolved: facebookexperimental#1610 NOTE: This is a breaking change, but the previous approach had a bug. Previously, `useRecoilCallback()` would attempt to provide a `Snapshot` based on the state that was currently rendered. However, there were some bugs where this was not the case. For example, a callback called from an effect handler may or may not have had the latest rendered state based on the timing of the setter. The new approach `useRecoilCallback()` will always try to get a snapshot with the latest state. This should also be more intuitive for users. Addresses facebookexperimental#1604 Reviewed By: habond Differential Revision: D34236485 fbshipit-source-id: fc10621f4569bff753c1755b4c2e41601d6b8069
|
This pull request was exported from Phabricator. Differential Revision: D34236485 |
drarmstr
force-pushed
the
export-D34236485
branch
from
9376272
to
062de4c
Compare
Yes, it seems that our internal build avoids the circular dependency when using non-dereferencing imports while the open source build does not. I'll have to break the circular dependency another way. |
…tal#1610) Summary: Pull Request resolved: facebookexperimental#1610 NOTE: This is a breaking change, but the previous approach had a bug. Previously, `useRecoilCallback()` would attempt to provide a `Snapshot` based on the state that was currently rendered. However, there were some bugs where this was not the case. For example, a callback called from an effect handler may or may not have had the latest rendered state based on the timing of the setter. The new approach `useRecoilCallback()` will always try to get a snapshot with the latest state. This should also be more intuitive for users. Addresses facebookexperimental#1604 Reviewed By: habond Differential Revision: D34236485 fbshipit-source-id: b8c79540e1e86fe8228bd32b4f003b7254d17f88
drarmstr
force-pushed
the
export-D34236485
branch
from
062de4c
to
06d76e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34236485 |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1610 NOTE: This is a breaking change, but the previous approach had a bug. Previously, `useRecoilCallback()` would attempt to provide a `Snapshot` based on the state that was currently rendered. However, there were some bugs where this was not the case. For example, a callback called from an effect handler may or may not have had the latest rendered state based on the timing of the setter. The new approach `useRecoilCallback()` will always try to get a snapshot with the latest state. This should also be more intuitive for users. Addresses #1604 Reviewed By: habond Differential Revision: D34236485 fbshipit-source-id: 0cb17cec40b50e8debeb57dc193b9f410d170fc5
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1610 NOTE: This is a breaking change, but the previous approach had a bug. Previously, `useRecoilCallback()` would attempt to provide a `Snapshot` based on the state that was currently rendered. However, there were some bugs where this was not the case. For example, a callback called from an effect handler may or may not have had the latest rendered state based on the timing of the setter. The new approach `useRecoilCallback()` will always try to get a snapshot with the latest state. This should also be more intuitive for users. Addresses #1604 Reviewed By: habond Differential Revision: D34236485 fbshipit-source-id: 0cb17cec40b50e8debeb57dc193b9f410d170fc5
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1610 NOTE: This is a breaking change, but the previous approach had a bug. Previously, `useRecoilCallback()` would attempt to provide a `Snapshot` based on the state that was currently rendered. However, there were some bugs where this was not the case. For example, a callback called from an effect handler may or may not have had the latest rendered state based on the timing of the setter. The new approach `useRecoilCallback()` will always try to get a snapshot with the latest state. This should also be more intuitive for users. Addresses #1604 Reviewed By: habond Differential Revision: D34236485 fbshipit-source-id: 0cb17cec40b50e8debeb57dc193b9f410d170fc5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NOTE: This is a breaking change, but the previous approach had a bug.
Previously,
useRecoilCallback()would attempt to provide aSnapshotbased on the state that was currently rendered. However, there were some bugs where this was not the case. For example, a callback called from an effect handler may or may not have had the latest rendered state based on the timing of the setter.The new approach
useRecoilCallback()will always try to get a snapshot with the latest state. This should also be more intuitive for users.Addresses #1604
Differential Revision: D34236485