This repository has been archived by the owner on May 30, 2022. It is now read-only.
Formatted everything with isort and black #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
SelleslaghGianni
force-pushed
the
black-isort-format
branch
from
78f9e7b
to
bda4fb0
Compare
Closed
|
@AndreasBackx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
AhmedSoliman
suggested changes
Oct 25, 2021
|
@AndreasBackx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I seem to have screwed something up while trying to rebase main into this branch to account for the earlier merged PR. I'm going to try and fix it later today |
SelleslaghGianni
force-pushed
the
black-isort-format
branch
from
944e7c6
to
73e4009
Compare
|
@AndreasBackx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I believe the commit-spaghetti should be fixed now :) |
AhmedSoliman
approved these changes
Oct 26, 2021
|
@AndreasBackx merged this pull request in cbce1d0. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
Summary: I was looking for something to do when I came across this repo. I saw the stale PR and wanted to take a crack at it. As for the formatting done in some files, I use black and at first I didn't pay attention until I noticed it here. I read in the contributing file that black is being used, so I'm hoping those changes are OK. I tried to follow the comments given to the previous PR as closely as I could, but I may have done something completely wrong, so I am open for feedback. I've rebased the commits made by esciara and the other PR's I've made. Edit: This is based on #84 Pull Request resolved: #81 Reviewed By: AhmedSoliman Differential Revision: D31782837 Pulled By: AndreasBackx fbshipit-source-id: 0d64722f78b30712859bb8bdf1f4c6d5efb1f266
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the comments on #81 this formats all the code using isort and black according to contributing guidelines. This is based on #82