This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
If a function is referenced before it's natural insertion point, #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanventer
approved these changes
Apr 26, 2017
src/serializer/serializer.js
Outdated
| this._delay(delayReason, [descValue], serializeFunc, mightHaveBeenDeleted); | ||
| invariant(!this._shouldDelayValues([descValue, val]), "precondition of _emitProperty"); | ||
| if (mightHaveBeenDeleted) { | ||
| this._delay(true, [], serializeFunc, true); |
There was a problem hiding this comment.
This last argument does not correspond to a parameter of _delay.
test/serializer/basic/Bind.js
Outdated
| // does not contain: bind | ||
| (function() { | ||
| function f() { | ||
| return function() { /* This comment makes this funciton too big to be inlined */ return 42; } |
NTillmann
force-pushed
the
Issue449
branch
2 times, most recently
from
58e0937 to
c6b4f50
Compare
we cannot apply the optimization that emits "var f = ...bind(...); " calls. Added positive and negative test. While at it, reviewed some places where code emission was delayed for no reason.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we cannot apply the optimization that emits "var f = ...bind(...); " calls.
Added positive and negative test.
This addresses #449.
While at it, reviewed some places where code emission was delayed for no reason and turned potential delaying to checking invariants.