Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Add 'joined' field to cast in DateTime #950

Merged
merged 2 commits into from
Jul 6, 2018
Merged

Add 'joined' field to cast in DateTime #950

merged 2 commits into from
Jul 6, 2018

Conversation

tolbon
Copy link
Contributor

@tolbon tolbon commented Feb 21, 2018

No description provided.

Copy link
Contributor

@yguedidi yguedidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tolbon! Can you please update the changelog? BTW, would you provide me a like to the node that provide this field? :)

@tolbon
Copy link
Contributor Author

tolbon commented Feb 27, 2018

Yeah I can do that,
That's an undocumented feature of Facebook Consumer Graph API but
I have an example of Workplace by Facebook but it's work for Facebook Consumer
Workplace Docs in "Example" section you see

GET graph.facebook.com
  /{group-id}/members?fields=name,id,joined

@SammyK SammyK added this to the 5.6.3 milestone Jul 3, 2018
@SammyK
Copy link
Contributor

SammyK commented Jul 3, 2018

Hey @yguedidi! If you approve this, I'll update the changelog. :)

@SammyK SammyK modified the milestones: 5.6.3, 5.7.0 Jul 3, 2018
@yguedidi
Copy link
Contributor

yguedidi commented Jul 3, 2018

@SammyK I approved, but regarding git, I'm more in favor the rebase strategy than the merge strategy to update a PR: it provides a cleaner git history :)

@SammyK
Copy link
Contributor

SammyK commented Jul 3, 2018

@yguedidi Thanks! I'm also a big rebase fan. I was just testing out this button:

screen shot 2018-07-03 at 6 01 46 pm

I guess I know what it does now! Lol. :)

@SammyK SammyK merged commit 62ba2c9 into facebookarchive:5.x Jul 6, 2018
SammyK added a commit to SammyK/php-graph-sdk that referenced this pull request Jul 6, 2018
phaizullin pushed a commit to phaizullin/php-graph-sdk that referenced this pull request Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants