Fix #1076

[bytestream]

closes #1076

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[yguedidi]

@bytestream thanks for this contribution! It looks like the branch is not up to date and that ou have to sign the CLA. Do you plan to do so? @jestinas also opened a fix for the bug, but you opened it first so either you update your PR and I accept yours, or let @jestinas update his PR. :)

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[bytestream]

@yguedidi signed and updated.

If you could tag a 5.6 release that would be great.

[yguedidi]

Thanks @bytestream! Can you please also update the changelog and add a test for this case so it doesn't break later? thanks again

[yguedidi]

final changes! please also squash your PR in one commit, then I'll merge it, thanks!

[bytestream]

Squashed 👍

[yguedidi]

Thanks @bytestream! will be release soon, once the 5.7.0 milestone is completed!

[julienbourdeau]

Any ETA for the 5.7 release? 🙏 The milestone seems complete.

[julienbourdeau]

Until this is released, I had to use my fork to use the current branch, I'll get rid of this when 5.7 is out.

If you're interested:

1. fork repository
2. update composer.json

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/julienbourdeau/php-graph-sdk"
        }
    ],
    "require": {
        "php": "^7.1.3",
        "facebook/graph-sdk": "5.x-dev"
    },

3. delete vendor folder (just in case) rm -rf vendor/facebook
4. Update with composer update

[yguedidi]

@julienbourdeau 5.7.0 finally released! Sorry for the delay!

[julienbourdeau]

@yguedidi Great! Thanks, I didn't expect it before christmas. 💯