-
Notifications
You must be signed in to change notification settings - Fork 630
adds absolute path to oembed GET as DEFAULT_ENDPOINT is not supported #163
base: master
Are you sure you want to change the base?
Conversation
@@ -21,7 +21,7 @@ module Embedding | |||
def oembed(*args) | |||
url = args.first | |||
return nil unless url | |||
get("oembed?url=#{url}", {}, false, false, true) | |||
get("/https://api.instagram.com/oembed?url=#{url}", {}, false, false, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just change this to:
get("/oembed?url=#{url}", {}, false, false, true)
That's how we've monkey-patched it to fix it. That way, it still uses the configuration's endpoint, but throws away the /v1
path.
@fusion2004 thanks, wasn't sure that'd work. Def makes it a simpler solution |
When will this be pulled in? The issue and PR have been open for 2 months now. |
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
+1 |
3 similar comments
+1 |
+1 |
+1 |
+1. |
+1 |
Looks like this no longer works. The oembed endpoint has changed multiple times and does not seem to consistent with the rest of the API. For this to work with the current API the method would need to be changed to:
|
fix for issue #162