This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[WIP][ASLayoutTransition] Relayout a node if one of its subnodes has a new size after layout transition #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
force-pushed
the
HNLayoutTransitionBugs
branch
from
3a48122 to
5bbb896
Compare
… moved in a recent PR (facebookarchive#2820)" This reverts commit 7872cfb.
nguyenhuy
force-pushed
the
HNLayoutTransitionBugs
branch
from
27cf9df to
f88f4bb
Compare
nguyenhuy
force-pushed
the
HNLayoutTransitionBugs
branch
from
f88f4bb to
14ce2bd
Compare
garrettmoon
reviewed
Jan 5, 2017
| // Hold onto __instanceLock__ until at least after the animation of this transtion kicked off, | ||
| // to make sure this transition isn't invalidated after it passed the abort test below | ||
| __instanceLock__.lock(); | ||
| if ([self _shouldAbortTransitionWithID:transitionID]) { | ||
| return; |
There was a problem hiding this comment.
Should this unlock here before the return?
There was a problem hiding this comment.
Good catch! It's very hard to hit this line (excepts for super busy nodes, like closeup) but it's a legitimate mistake of mine!
|
I tested this out on my product code and it doesn't work in my case. Huy has the repro steps and will double check to see if it's a bug on my side or ASDK's side. |
nguyenhuy
changed the title
nguyenhuy
changed the title
nguyenhuy
changed the title
|
Closing this in favor of an overhaul of the layout system. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_transitionInProgressflag is turned off before that, any layout pass occurs afterward, but before-transitionContext:didComplete:is called, can erase all pending states of the transition, causing old subviews to remain in the hierarchy forever.@maicki, @garrettmoon, @appleguy, @Adlai-Holler: Would love to have your feedbacks here.
@hannahmbanana Please help me to test this diff with Pinterest master. I already did that, as well as with ASDKLayoutTransition example and the sample projects in #2841 and #2816. However, with all the branch and context switchings, I may overlooked something. Gonna test it more tomorrow!