formatString_u() can display numbers > 100 #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixhandte
reviewed
Aug 8, 2024
Comment on lines
+142
to
+150
| static size_t uintSize(unsigned value) | ||
| { | ||
| size_t size = 1; | ||
| while (value >= 10) { | ||
| size++; | ||
| value /= 10; | ||
| } | ||
| return size; | ||
| } |
There was a problem hiding this comment.
This solution has an admirable simplicity, but there are reasonably compact, if non-obvious, fast solutions available:
https://lemire.me/blog/2021/06/03/computing-the-number-of-digits-of-an-integer-even-faster/
There was a problem hiding this comment.
Nice reference !
This could be useful in a hot conversion to ascii loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmark can now run on > 100 files without option
-S.fixes #4110