Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decompress: add -DZSTD_DISABLE_FAST_C_LOOP to disable fast C loops #3778

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

iksaif
Copy link

@iksaif iksaif commented Sep 28, 2023

#3762 seems to show that it doesn't perform as well as we though it would in many cases. It makes sense to at least allow users to disable them at buildtime and runtime.

facebook#3762 seems to show
that it doesn't perform as well as we though it would in many
cases. It makes sense to at least allow users to disable them
at buildtime and runtime.
@facebook-github-bot
Copy link

Hi @iksaif!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@terrelln
Copy link
Contributor

terrelln commented Mar 4, 2024

HUF_DISABLE_FAST_DECODE does this, it is documented in lib/decompress/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants