Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZSTD_set{C,F,}Params() helper functions #3530

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Add ZSTD_set{C,F,}Params() helper functions #3530

merged 1 commit into from
Mar 8, 2023

Conversation

terrelln
Copy link
Contributor

@terrelln terrelln commented Mar 7, 2023

  • Add ZSTD_setFParams() and ZSTD_setParams()
  • Modify ZSTD_setCParams() to use ZSTD_setParameter() to avoid a second path setting parameters
  • Add unit tests
  • Update documentation to suggest using them to replace deprecated functions

Fixes #3396.

Add ZSTD_set{C,F,}Params() helper functions
c7dce80 
* Add ZSTD_setFParams() and ZSTD_setParams()
* Modify ZSTD_setCParams() to use ZSTD_setParameter() to avoid a second path setting parameters
* Add unit tests
* Update documentation to suggest using them to replace deprecated functions

Fixes facebook#3396.
@terrelln terrelln force-pushed the 2023-03-07-issue-3396 branch from fa9af3e to c7dce80 Compare March 7, 2023 23:23
@terrelln terrelln merged commit 07a2a33 into facebook:dev Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add helper functions to set ZSTD_parameters on a cctx or cctxParams
3 participants
@terrelln @Cyan4973 @facebook-github-bot