Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify benchmark unit invocation API from CLI #3526

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Simplify benchmark unit invocation API from CLI #3526

merged 3 commits into from
Mar 9, 2023

Conversation

Cyan4973
Copy link
Contributor

@Cyan4973 Cyan4973 commented Mar 6, 2023

fix #3481

Cyan4973 added 3 commits March 6, 2023 12:15
@Cyan4973
simplify BMK_syntheticTest()
db79219
@Cyan4973
minor: fixed zlib wrapper internal benchmark
9efc148 
another possibility could be to link it to programs/benchfn .
Not worth the effort.
@Cyan4973
simplified BMK_benchFilesAdvanced()
1e38e07
@Cyan4973 Cyan4973 self-assigned this Mar 6, 2023
@Cyan4973 Cyan4973 merged commit e769da1 into dev Mar 9, 2023
@Cyan4973 Cyan4973 deleted the bench_zstd_api branch March 29, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrelln terrelln terrelln approved these changes

Assignees

@Cyan4973 Cyan4973

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor invocation of benchmark module from the zstdcli.c
3 participants
@Cyan4973 @terrelln @facebook-github-bot