CI Workflow for external compressors dependencies #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoniko
force-pushed
the
ci-build-compressors-support
branch
from
732a9ec to
48e49b7
Compare
…sors and with no external compressors. This is a sanity to make sure we don't introduce code dependencies on libraries that don't always exist (see facebook#3497 for an example bugfix for such issue).
yoniko
force-pushed
the
ci-build-compressors-support
branch
from
48e49b7 to
9daf04b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented CI workflow for testing compilation with external compressors and without them. This serves as a sanity check to avoid any code dependencies on libraries that may not always be present. (Reference: #3497 for a bug fix related to this issue.)
Note: the new job added here is expected to fail as #3497 isn't merged yet.
This will give us confirmation that it does find the issue.
After #3497 this will be rebased to make sure the job doesn't fail anymore.