Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more gzip compatibility (#3037) #3059

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

dirkmueller
Copy link
Contributor

-n --no-name is the current behavior already, so we can implement
this as a noop.

--best is an alias for -9 in gzip

add basic cli tests.

Copy link
Contributor

@felixhandte felixhandte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These options should be documented in the CLI help text and in the man page. Can you add descriptions?

(If you'd prefer we do that part, we can add them in a follow-up PR.)

@dirkmueller dirkmueller changed the title Implment more gzip compatibility (#3037) Implement more gzip compatibility (#3037) Feb 9, 2022
-n --no-name is the current behavior already, so we can implement
this as a noop.

--best is an alias for -9 in gzip

add basic cli tests.
@dirkmueller
Copy link
Contributor Author

@felixhandte Okay, wasn't sure as these options are just for better gzip compatibility and not exposed in standard zstd cli. anyway added.

@dirkmueller dirkmueller requested a review from felixhandte March 8, 2022 19:34
@dirkmueller
Copy link
Contributor Author

is there anything I can do to move this forward?

Copy link
Contributor

@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

Copy link
Contributor

@felixhandte felixhandte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder. Let's ship it!

@felixhandte felixhandte merged commit 8814aa5 into facebook:dev Mar 8, 2022
@Cyan4973 Cyan4973 mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants