Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error caused by -Werror=class-memaccess #823

Closed
wants to merge 2 commits into from
Closed

Fix build error caused by -Werror=class-memaccess #823

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e334869
Fix build error caused by -Werror=class-memaccess on gcc 8.2.1 and cl…
hooddanielc Oct 7, 2018
3b2dee8
Use YGLayout default constructor instead of memset for YGZeroOutLayou…
hooddanielc Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion yoga/Yoga.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1851,7 +1851,9 @@ static bool YGNodeFixedSizeSetMeasuredDimensions(
}

static void YGZeroOutLayoutRecursivly(const YGNodeRef node) {
memset(&(node->getLayout()), 0, sizeof(YGLayout));
node->getLayout() = {};
node->setLayoutDimension(0, 0);
node->setLayoutDimension(0, 1);
node->setHasNewLayout(true);
node->cloneChildrenIfNeeded();
const uint32_t childCount = YGNodeGetChildCount(node);
Expand Down