Suppress unused warnings on YGDefaultLog #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woehrl01
force-pushed
the
supress_unused
branch
from
a0628b1 to
f888b26
Compare
|
👍 |
There was a problem hiding this comment.
@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 28, 2017
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes #650 Closes #651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 28, 2017
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes #650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes facebook#650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes facebook#650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
vincentriemer
pushed a commit
to vincentriemer/yoga-dom
that referenced
this pull request
May 9, 2018
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes #650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses the unused warnings on
YGDefaultLog. It uses a more generic macro which simply casts the variable to(void). This is the simples approach to make mutiple different compilers happy. Fixes #650