Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Update YogaConfig #496

Closed
wants to merge 1 commit into from
Closed

[C#] Update YogaConfig #496

wants to merge 1 commit into from

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Mar 29, 2017

  • Bugfix: Retain managed YogaConfig to prevent releasing unmanaged YogaConfig
  • Use the same YogaConfig in the copy constructor
  • Expose Set/GetUseWebDefaults APIs
  • Split YogaConfig out from YogaNode.cs

@splhack
[C#] Update YogaConfig
8eed68e 
- Bugfix: Retain managed YogaConfig to prevent releasing unmanaged YogaConfig
- Use the same YogaConfig in the copy constructor
- Expose Set/GetUseWebDefaults APIs
- Split YogaConfig out from YogaNode.cs
@splhack splhack mentioned this pull request Mar 29, 2017
Closed
@facebook-github-bot
Copy link
Contributor

@splhack has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Apr 10, 2017
@splhack @facebook-github-bot
Add YGConfigGetInstanceCount
8a45ed9 
Summary:
- depends on #496
- For memory leak unit test
- Expose the API for C#
Closes #497

Reviewed By: emilsjolander

Differential Revision: D4796190

Pulled By: splhack

fbshipit-source-id: 99e4e78e8dfb3d459cf6cd7103ab252c3748e5a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@splhack @facebook-github-bot