Update iOS Sample, migrate to Swift5. #1105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jun 6, 2023
Summary: This gets `pod lib lint` and building the sample app with xcbuild passing (using facebook#1105 as a template). Differential Revision: D46470738 fbshipit-source-id: 80e402fd432e280c8ee187420e41021d3c06dec6
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jun 6, 2023
Summary: Pull Request resolved: facebook#1303 This gets `pod lib lint` and building the sample app with xcbuild passing (using facebook#1105 as a template). Differential Revision: D46470738 fbshipit-source-id: f61eb44c533e1a5fd8c2df0807e2cfd80418406d
|
I added 4fc1657 which updated us to Swift 5.1, and used some of the changes here (esp around IGListKit update). Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.