return value from getGap method

facebook · Dec 7, 2022 · df9f016 · df9f016
1 parent 5e75051
commit df9f016
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/javascript/sources/Node.cc b/javascript/sources/Node.cc
@@ -331,8 +331,8 @@ Value Node::getPadding(int edge) const {
       YGNodeStyleGetPadding(m_node, static_cast<YGEdge>(edge)));
 }
 
-float Node::getGap(int gutter) {
-  return YGNodeStyleGetGap(m_node, static_cast<YGGutter>(gutter));
+Value Node::getGap(int gutter) {
+  return Value(static_cast<int>(YGUnitPercent), YGNodeStyleGetGap(m_node, static_cast<YGGutter>(gutter)));
 }
 
 bool Node::isReferenceBaseline() {

diff --git a/javascript/sources/Node.hh b/javascript/sources/Node.hh
@@ -158,7 +158,7 @@ public: // Style getters
 
   Value getPadding(int edge) const;
 
-  float getGap(int gutter);
+  Value getGap(int gutter);
 
 public: // Tree hierarchy mutators
   void insertChild(Node* child, unsigned index);