Skip to content

Commit

Permalink
fix missing dll exports (#1127)
Browse files Browse the repository at this point in the history
Summary:
When I use libyogacore.so in other programming languages, it crash with message as

> Could not obtain symbol from the library: dlsym(0x20b84d220, YGConfigIsExperimentalFeatureEnabled): symbol not found

This function is defined as `WIN_EXPORT bool YGConfigIsExperimentalFeatureEnabled` in yoga.h, but is not defined using `YOGA_EXPORT` in yoga.cpp.

Pull Request resolved: #1127

Reviewed By: yungsters

Differential Revision: D40024450

Pulled By: yungsters

fbshipit-source-id: f6f01eadccb13d593c68300059e96f4b0bbc9fb6
  • Loading branch information
justjavac authored and facebook-github-bot committed Oct 4, 2022
1 parent 572f525 commit 29c2151
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions yoga/Yoga.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ YOGA_EXPORT void YGNodeReset(YGNodeRef node) {
node->reset();
}

int32_t YGConfigGetInstanceCount(void) {
YOGA_EXPORT int32_t YGConfigGetInstanceCount(void) {
return gConfigInstanceCount;
}

Expand Down Expand Up @@ -4324,7 +4324,7 @@ YOGA_EXPORT void YGConfigSetExperimentalFeatureEnabled(
config->experimentalFeatures[feature] = enabled;
}

inline bool YGConfigIsExperimentalFeatureEnabled(
YOGA_EXPORT bool YGConfigIsExperimentalFeatureEnabled(
const YGConfigRef config,
const YGExperimentalFeature feature) {
return config->experimentalFeatures[feature];
Expand Down

0 comments on commit 29c2151

Please sign in to comment.