fix: bump sysinfo to 0.32.1 #1255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeing some build failure as in GuillaumeGomez/sysinfo#1392 while building the latest release. Bumping sysinfo crate to 0.32.1 fixed the issue, relates to Homebrew/homebrew-core#198962 Signed-off-by: Rui Chen <[email protected]>
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
any update on the thread? thanks! |
|
@AjanthanAsogamoorthy can you also help with this PR? thanks! |
|
@chenrui333 is this because you are picking up a newer libc crate or some other updated dep, and do you have a workaround to lock libc or whatever dep is causing issues in the homebrew builds? |
|
I think with the newer libc crate release, I dont need the patch anymore, thanks for weighing in here. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seeing some build failure as in GuillaumeGomez/sysinfo#1392 while building the latest release.
Bumping sysinfo crate to 0.32.1 fixed the issue, relates to Homebrew/homebrew-core#198962
fixes #1254