📝 Updated stylex.create docs #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Referenced typescript limitation in using the new `const` keyword
facebook-github-bot
added
the
CLA Signed
|
@nmn Here's the PR, I wasn't sure about the references but I added them anyway. Please let me know if I missed anything |
nmn
reviewed
Jan 11, 2024
nmn
requested changes
Jan 11, 2024
necolas
requested changes
Jan 11, 2024
nmn
reviewed
Jan 15, 2024
| @@ -25,6 +25,9 @@ The recommended way to use StyleX in development and production is with the | |||
| build-time compiler. | |||
|
|
|||
| ### Development | |||
| :::danger TypeScript Limitation | |||
There was a problem hiding this comment.
The title should be changed. I'll think about what it should be.
|
I'm closing this PR. I'll update the docs with the minimum typescript requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
Documentation changes, added a warning for typescript users using TS < 5
Linked PR/Issues
Fixes #327
Additional Context
Referenced typescript limitation in using the new
constkeywordPre-flight checklist
Contribution Guidelines