stylex.create({}) show error TS2554: Expected 0 arguments, but got 1

[romanchekashov]

Please remove const from:

export type Stylex$Create = <
  const S extends {
    [key: string]: UserAuthoredStyles | ((...args: any) => UserAuthoredStyles);
  },
>(
  styles: S,
) => MapNamespaces<S>;

stylex/packages/stylex/src/StyleXTypes.d.ts

Line 108 in a3528b6

const S extends {

[romanchekashov]

I've created a pull request with fix: #314

[nmn]

The const is needed. Without it, the types aren't specific enough.

Please share an example of the issue you're seeing.

[romanchekashov]

You can see bellow highlights. If I remove const error disappears.

[romanchekashov]

I thought that const cannot be used inside generics <...> but maybe this bug related to IntelliJ IDEA 2023.2.2?

[nmn]

const can be used within generics for functions and classes, but not type aliases.

This feels like an IntelliJ bug. This all works in VS Code. Leaving the issue open for you to verify on your end.

[daulric]

const can be used within generics for functions and classes, but not type aliases.

This feels like an IntelliJ bug. This all works in VS Code. Leaving the issue open for you to verify on your end.

i had that error but I didn't know when I was using VSCode as well. This is an error on Stylex Side

[daulric]

this is the error i had

[bmg02]

I'm facing the same error. Any solution for this?

[nmn]

You're most likely using an old version of Typescript. As you can see on the nextjs example in the repo itself, there are no typescript errors.

Can you both verify the version of Typescript you're using?

[romanchekashov]

const can be used within generics for functions and classes, but not type aliases. - This is a new feature of latest TypeScript 5.3.3 and doesn't work with TS 4.8.4;(

Just upgrade TS version in package.json with "typescript": "^5.3.3".

@nmn Please provide example of running jest tests in Nextjs 14 with stylexjs? I've managed a lot to be able to use stylexjs with Next js 14 but I cannot move further with falling tests( I'm using Jest with React Testing Library and getting error:

 ● Test suite failed to run

    stylex.defineVars should never be called. It should be compiled away.

      82 | };
      83 |
    > 84 | export const text = stylex.defineVars({

[bmg02]

Upgrading the typescript solved the issue, thanks.

[nmn]

Added a single Jest snapshot test in this repo:

https://github.com/nmn/nextjs-app-dir-stylex