Fix missing comma in Stmt::Load Display impl #132
Conversation
|
Hi @rossdylan! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Looks good. Can you sign CLA please? |
Thanks! Working on that, I need to figure out how to get this covered by the existing CLA my company has signed |
|
I'll fix the tests that expect the invalid output too |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@stepancheg has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@stepancheg merged this pull request in 8b2f376. |
Summary: I was exploring using starlark_syntax to merge BUILD files together, and noticed that it generates invalid load statements. Its a simple fix, we just add a comma that was missing from the Display impl. This is the same as facebook/starlark-rust#131 just from my work github org so the CLA automation works correctly. X-link: facebook/starlark-rust#132 Reviewed By: KapJI Differential Revision: D65606766 Pulled By: stepancheg fbshipit-source-id: baeb88a29470546f30becc38a9f8a5e1ff727f4d
|
Thanks! |
I was exploring using starlark_syntax to merge BUILD files together, and noticed that it generates invalid load statements. Its a simple fix, we just add a comma that was missing from the Display impl.
This is the same as #131 just from my work github org so the CLA automation works correctly.