Skip to content

Commit

Permalink
memory: Remove failing unit test
Browse files Browse the repository at this point in the history
Summary:
This test was added a few days ago in D56701219 and has been failing ever since.

In [the sandcastle logs](https://www.internalfb.com/sandcastle/workflow/1265511495293864711/actions) for oss-mononoke-linux-getdeps, we can see:
```
failures:

---- test::test_get_stats_no_max_set stdout ----
thread 'test::test_get_stats_no_max_set' panicked at common/memory/src/lib.rs:63:9:
assertion failed: stats.is_err()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    test::test_get_stats_no_max_set

test result: FAILED. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

```

Reviewed By: gustavoavena

Differential Revision: D56830459

fbshipit-source-id: 62145b8d3972d8c1b3263fb31e3559390d1f58ba
  • Loading branch information
Pierre Chevalier authored and facebook-github-bot committed May 3, 2024
1 parent c9d1f9e commit ab34ffc
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions eden/mononoke/common/memory/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,6 @@ fn populate_stats(max_memory: usize, used_mem: usize) -> MemoryStats {
mod test {
use super::*;

#[test]
fn test_get_stats_no_max_set() {
let stats = get_stats();
assert!(stats.is_err());
assert_eq!(stats.err().unwrap(), "max_memory is not set");
}

#[test]
fn test_get_stats() {
let old = MAX_MEMORY.load(Ordering::Relaxed);
Expand Down

0 comments on commit ab34ffc

Please sign in to comment.