-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C] Port the batched version of MultiGet() to RocksDB's C API #9952
Conversation
The error on Travis CI - Pull Request seems transient and not related to this PR.
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi YH :), thanks for the PR. LGTM!
Thank you, @ajkr. Should I rebase or it's good to merge? |
Should be good to merge - just waiting for someone to accept the internal diff. |
Thank you. Let me know if there's anything that I should address. |
Hello, @ajkr. Can I know whether the PR looks good internally? |
Summary:
The batched version of MultiGet() is not available in RocksDB's C API.
This PR implements rocksdb_batched_multi_get_cf which is a C wrapper function
that invokes the batched version of MultiGet() which takes one single column family.
Test Plan:
Added a new test case under "columnfamilies" test case in c_test.cc