Add a benchmarking wrapper script for BlobDB #9015
Conversation
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…b files are enabled
…during the later tests instead
…om benchmark.sh (relying on the recently added extra parameters functionality, and reverting unnecessary changes along the way)
… using env variables
…erated by benchmark.sh)
ltamasi
force-pushed
the
blob_benchmark_scripts
branch
from
aedb4c9 to
0288c91
Compare
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| if [ $# -ge 1 ]; then | ||
| display_usage | ||
|
|
||
| if [ "$1" == "--help" ]; then |
There was a problem hiding this comment.
Not a shell expert. Would it be possible to use getopts for argument parsing here? Maybe it's not worth the effort for this script.
There was a problem hiding this comment.
Yeah, I think that would a bit of an overkill considering we only have a single optional command line argument...
Summary: The patch adds a new BlobDB benchmarking script called `run_blob_bench.sh`. It is a thin wrapper around `benchmark.sh` (similarly to `run_flash_bench.sh`): it actually calls `benchmark.sh` a number of times, cycling through six workloads, two write-only ones (bulk load and overwrite), two read/write ones (point lookups while writing, range scans while writing), and two read-only ones (point lookups and range scans). Note: this is a simpler/cleaned up/reworked version of the script used to produce the benchmark results in http://rocksdb.org/blog/2021/05/26/integrated-blob-db.html . The new version takes advantage of several recent `benchmark.sh` improvements like the ability to pass in arbitrary `db_bench` options or the possibility of using a job ID. Pull Request resolved: facebook/rocksdb#9015 Test Plan: Ran the script manually with different parameter combinations. Reviewed By: riversand963 Differential Revision: D31555277 Pulled By: ltamasi fbshipit-source-id: 0e151b2f7b2cf6f66ed7f95455571492ad7ea87f
Summary:
The patch adds a new BlobDB benchmarking script called
run_blob_bench.sh.It is a thin wrapper around
benchmark.sh(similarly torun_flash_bench.sh):it actually calls
benchmark.sha number of times, cycling through six workloads,two write-only ones (bulk load and overwrite), two read/write ones (point lookups
while writing, range scans while writing), and two read-only ones (point lookups
and range scans).
Note: this is a simpler/cleaned up/reworked version of the script used to produce the
benchmark results in http://rocksdb.org/blog/2021/05/26/integrated-blob-db.html .
The new version takes advantage of several recent
benchmark.shimprovementslike the ability to pass in arbitrary
db_benchoptions or the possibility of using ajob ID.
Test Plan:
Ran the script manually with different parameter combinations.