Update HISTORY.md for #8428 #9001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkr
approved these changes
Oct 8, 2021
HISTORY.md
Outdated
| @@ -46,6 +46,7 @@ | |||
| * Batch blob read requests for `DB::MultiGet` using `MultiRead`. | |||
| * Add support for fallback to local compaction, the user can return `CompactionServiceJobStatus::kUseLocal` to instruct RocksDB to run the compaction locally instead of waiting for the remote compaction result. | |||
| * Add built-in rate limiter's implementation of `RateLimiter::GetTotalPendingRequest(int64_t* total_pending_requests, const Env::IOPriority pri)` for the total number of requests that are pending for bytes in the rate limiter. | |||
| * Charge memory usage during data buffering, from which training samples are gathered for dictionary compression, to block cache. Unbuffering data can now be triggered if the block cache becomes full, in addition to existing conditions that can trigger unbuffering. | |||
There was a problem hiding this comment.
I think strict_capacity_limit=true is needed in addition to full cache to make the buffering stop early.
There was a problem hiding this comment.
Yes - good catch on this detail that we should be accurate!
|
Update:
|
|
@hx235 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
Update:
|
|
@hx235 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
hx235
force-pushed
the
update_history_for_dict_buffer_mem_accounting
branch
from
af9b4d0 to
df5226a
Compare
|
Update:
|
|
@hx235 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ajkr
pushed a commit
to ajkr/rocksdb
that referenced
this pull request
Oct 11, 2021
Summary: Context: HISTORY.md was not properly updated along with the change in facebook#8428, where we introduced a change of accounting compression dictionary buffering memory and an extra condition of triggering data unbuffering. Updated HISTORY.md for facebook#8428 in 6.25.0 HISTORY.md section. Updated blog post https://rocksdb.org/blog/2021/05/31/dictionary-compression.html. Pull Request resolved: facebook#9001 Reviewed By: ajkr Differential Revision: D31517836 Pulled By: hx235 fbshipit-source-id: 01f6b30de4e1ff6b315aa8221139d9b700c7c629
yoori
pushed a commit
to yoori/rocksdb
that referenced
this pull request
Nov 26, 2023
Summary: Context: HISTORY.md was not properly updated along with the change in facebook/rocksdb#8428, where we introduced a change of accounting compression dictionary buffering memory and an extra condition of triggering data unbuffering. Updated HISTORY.md for facebook/rocksdb#8428 in 6.25.0 HISTORY.md section. Updated blog post https://rocksdb.org/blog/2021/05/31/dictionary-compression.html. Pull Request resolved: facebook/rocksdb#9001 Reviewed By: ajkr Differential Revision: D31517836 Pulled By: hx235 fbshipit-source-id: 01f6b30de4e1ff6b315aa8221139d9b700c7c629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
HISTORY.md was not properly updated along with the change in #8428, where we introduced a change of accounting compression dictionary buffering memory and an extra condition of triggering data unbuffering.
Summary:
Updated HISTORY.md for #8428 in 6.25.0 HISTORY.md section.
Updated blog post https://rocksdb.org/blog/2021/05/31/dictionary-compression.html.