Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed const fields in copyable classes #5095

Closed
wants to merge 2 commits into from
Closed

Removed const fields in copyable classes #5095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c406a6b
Removed const fields in copyable classes
harrywong Mar 22, 2019
5f5d562
Align comments
harrywong Mar 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utilities/persistent_cache/block_cache_tier.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class BlockCacheTier : public PersistentCacheTier {

std::string key_;
std::string data_;
const bool signal_ = false; // signal to request processing thread to exit
bool signal_ = false; // signal to request processing thread to exit
};

// entry point for insert thread
Expand Down
10 changes: 5 additions & 5 deletions utilities/persistent_cache/block_cache_tier_file.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,11 @@ class ThreadedWriter : public Writer {
IO& operator=(const IO&) = default;
size_t Size() const { return sizeof(IO); }

WritableFile* file_ = nullptr; // File to write to
CacheWriteBuffer* const buf_ = nullptr; // buffer to write
uint64_t file_off_ = 0; // file offset
bool signal_ = false; // signal to exit thread loop
std::function<void()> callback_; // Callback on completion
WritableFile* file_ = nullptr; // File to write to
CacheWriteBuffer* buf_ = nullptr; // buffer to write
uint64_t file_off_ = 0; // file offset
bool signal_ = false; // signal to exit thread loop
std::function<void()> callback_; // Callback on completion
};

explicit ThreadedWriter(PersistentCacheTier* const cache, const size_t qdepth,
Expand Down