New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a lint error due to unspecified move evaluation order #4348

Closed

anand1976 wants to merge 1 commit into facebook:master from anand1976:move_order

Commits on Sep 6, 2018

Fix a lint error due to unspecified move evaluation order

Summary:
In C++ 11, the order of argument and move evaluation in a statement such
as below is unspecified -
  foo(a.b).bar(std::move(a))

In C++ 17, this will be safe if a draft proposal around function
chaining rules is accepted.

Test Plan:
make check

Reviewers:

Subscribers:

Tasks:

Tags:

Anand Ananthabhotla committed Sep 6, 2018