Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilities: Fix coverity issues #3155

Closed

Commits on Nov 10, 2017

  1. utilities: Fix coverity issues

    Summary:
    utilities/persistent_cache/block_cache_tier_file.cc
    64struct CacheRecordHeader {
       	2. uninit_member: Non-static class member magic_ is not initialized in this constructor nor in any functions that it calls.
       	4. uninit_member: Non-static class member crc_ is not initialized in this constructor nor in any functions that it calls.
       	6. uninit_member: Non-static class member key_size_ is not initialized in this constructor nor in any functions that it calls.
    
    CID 1396161 (facebook#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
    8. uninit_member: Non-static class member val_size_ is not initialized in this constructor nor in any functions that it calls.
     65  CacheRecordHeader() {}
     66  CacheRecordHeader(const uint32_t magic, const uint32_t key_size,
     67                    const uint32_t val_size)
     68      : magic_(magic), crc_(0), key_size_(key_size), val_size_(val_size) {}
     69
       	1. member_decl: Class member declaration for magic_.
     70  uint32_t magic_;
       	3. member_decl: Class member declaration for crc_.
     71  uint32_t crc_;
       	5. member_decl: Class member declaration for key_size_.
     72  uint32_t key_size_;
       	7. member_decl: Class member declaration for val_size_.
     73  uint32_t val_size_;
     74};
    
    utilities/simulator_cache/sim_cache.cc:
    157        miss_times_(0),
    
    CID 1396124 (facebook#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
    2. uninit_member: Non-static class member stats_ is not initialized in this constructor nor in any functions that it calls.
    158        hit_times_(0) {}
    159
    Prashant D committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    f7a13a3 View commit details
    Browse the repository at this point in the history