-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and Fix JavaDoc issues in RocksJava #12149
Open
adamretter
wants to merge
14
commits into
facebook:main
Choose a base branch
from
evolvedbinary:eb/cleanup-native-handle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamretter
force-pushed
the
eb/cleanup-native-handle
branch
2 times, most recently
from
December 21, 2023 20:53
71c80cc
to
0efb705
Compare
adamretter
force-pushed
the
eb/cleanup-native-handle
branch
8 times, most recently
from
December 21, 2023 23:39
80632b6
to
ea76e36
Compare
adamretter
force-pushed
the
eb/cleanup-native-handle
branch
from
January 10, 2024 11:53
ea76e36
to
3f75252
Compare
adamretter
force-pushed
the
eb/cleanup-native-handle
branch
from
February 6, 2024 23:37
3f75252
to
7eae866
Compare
(https://github.com/facebook/rocksdb/actions/runs/7807589234/job/21296253965?pr=12149) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In total this resolves over 400 JavaDoc warnings/errors.