Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and recreate expected values dir in white-box testing 2nd half #10743

Closed
wants to merge 1 commit into from

Conversation

hx235
Copy link
Contributor

@hx235 hx235 commented Sep 27, 2022

Context:
#8913 (comment)

Test:

  • Locally run python3 ./tools/db_crashtest.py whitebox --simple -max_key=1000000 -value_size_mult=33 -write_buffer_size=524288 -target_file_size_base=524288 -max_bytes_for_level_base=2097152 --duration=120 --interval=10 --ops_per_thread=1000 --random_kill_odd=887
  • CI stress testing

@hx235 hx235 changed the title Remove and recreate expected values dir in white-box testing h2 Remove and recreate expected values dir in white-box testing 2nd half Sep 27, 2022
@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was it really failing silently? I thought whitebox crash test H2 should catch unexpected crashes since kill_random_test is often None

@hx235
Copy link
Contributor Author

hx235 commented Sep 29, 2022

LGTM. Was it really failing silently? I thought whitebox crash test H2 should catch unexpected crashes since kill_random_test is often None

Maybe the first half often runs super long so second half doesn't get to run many iterations to hit sync_fault_injection=1 (only after it is re-enabled is stress test) or disable_wal=1??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants