-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C] Add get_column_family_metadata() and related functions to C API #10207
[C] Add get_column_family_metadata() and related functions to C API #10207
Conversation
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, had a few questions
c0c79c1
to
579f04c
Compare
@yhchiang-sol has updated the pull request. You must reimport the pull request before landing. |
579f04c
to
2f31072
Compare
@yhchiang-sol has updated the pull request. You must reimport the pull request before landing. |
Addressed comments. Also adding test cases covering get_column_family_metadata_cf(). |
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
2f31072
to
e065d80
Compare
@yhchiang-sol has updated the pull request. You must reimport the pull request before landing. |
e065d80
to
5f87490
Compare
@yhchiang-sol has updated the pull request. You must reimport the pull request before landing. |
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
rocksdb_get_column_family_metadata()
androcksdb_get_column_family_metadata_cf()
that returns
rocksdb_column_family_metadata_t
.rocksdb_column_family_metadata_t
and its get functions & destroy function.rocksdb_level_metadata_t
and its and its get functions & destroy function.rocksdb_file_metadata_t
and its and get functions & destroy functions.Test Plan:
Extend the existing c_test.c to include additional checks for column_family_metadata
inside CheckCompaction.