Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Add get_column_family_metadata() and related functions to C API #10207

Closed

Conversation

yhchiang-sol
Copy link
Contributor

Summary:

  • Add metadata related structs and functions in C API, including
    • rocksdb_get_column_family_metadata() and rocksdb_get_column_family_metadata_cf()
      that returns rocksdb_column_family_metadata_t.
    • rocksdb_column_family_metadata_t and its get functions & destroy function.
    • rocksdb_level_metadata_t and its and its get functions & destroy function.
    • rocksdb_file_metadata_t and its and get functions & destroy functions.

Test Plan:
Extend the existing c_test.c to include additional checks for column_family_metadata
inside CheckCompaction.

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, had a few questions

db/c.cc Show resolved Hide resolved
include/rocksdb/c.h Outdated Show resolved Hide resolved
include/rocksdb/c.h Outdated Show resolved Hide resolved
include/rocksdb/c.h Outdated Show resolved Hide resolved
db/c_test.c Show resolved Hide resolved
@yhchiang-sol yhchiang-sol force-pushed the c-get-column-family-metadata branch from c0c79c1 to 579f04c Compare June 21, 2022 16:12
@facebook-github-bot
Copy link
Contributor

@yhchiang-sol has updated the pull request. You must reimport the pull request before landing.

@yhchiang-sol yhchiang-sol force-pushed the c-get-column-family-metadata branch from 579f04c to 2f31072 Compare June 21, 2022 16:19
@facebook-github-bot
Copy link
Contributor

@yhchiang-sol has updated the pull request. You must reimport the pull request before landing.

@yhchiang-sol
Copy link
Contributor Author

Addressed comments. Also adding test cases covering get_column_family_metadata_cf().

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@yhchiang-sol yhchiang-sol force-pushed the c-get-column-family-metadata branch from 2f31072 to e065d80 Compare June 22, 2022 02:13
@facebook-github-bot
Copy link
Contributor

@yhchiang-sol has updated the pull request. You must reimport the pull request before landing.

@yhchiang-sol yhchiang-sol force-pushed the c-get-column-family-metadata branch from e065d80 to 5f87490 Compare June 22, 2022 13:56
@facebook-github-bot
Copy link
Contributor

@yhchiang-sol has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants