Skip to content

Commit

Permalink
Disable DBIOFailureTest.NoSpaceCompactRange in LITE (#4596)
Browse files Browse the repository at this point in the history
Summary:
Since ErrorHandler::RecoverFromNoSpace is no-op in LITE mode, then we should
not have this test in LITE mode. If we do keep it, it will cause the test
thread to wait on bg_cv_ that will not be signalled.

How to reproduce
```
$make clean && git checkout a27fce4
$OPT="-DROCKSDB_LITE -g" make -j20
$./db_io_failure_test --gtest_filter=DBIOFailureTest.NoSpaceCompactRange
```
Pull Request resolved: #4596

Differential Revision: D12818516

Pulled By: riversand963

fbshipit-source-id: bc83524f40fff1e29506979017f7f4c2b70322f3
  • Loading branch information
riversand963 authored and facebook-github-bot committed Oct 29, 2018
1 parent 7fb39f1 commit 806ff34
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion db/db_io_failure_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ TEST_F(DBIOFailureTest, DropWritesFlush) {
env_->drop_writes_.store(false, std::memory_order_release);
} while (ChangeCompactOptions());
}
#endif // ROCKSDB_LITE

// Check that CompactRange() returns failure if there is not enough space left
// on device
Expand Down Expand Up @@ -116,6 +115,7 @@ TEST_F(DBIOFailureTest, NoSpaceCompactRange) {
env_->no_space_.store(false, std::memory_order_release);
} while (ChangeCompactOptions());
}
#endif // ROCKSDB_LITE

TEST_F(DBIOFailureTest, NonWritableFileSystem) {
do {
Expand Down

0 comments on commit 806ff34

Please sign in to comment.