Skip to content

Commit

Permalink
Update HISTORY for PR 8994 (#9017)
Browse files Browse the repository at this point in the history
Summary:
Also, expand on/clarify a comment in `VersionStorageInfoTest`.

Pull Request resolved: #9017

Reviewed By: riversand963

Differential Revision: D31566130

Pulled By: ltamasi

fbshipit-source-id: 1d30c7af084c4de7b2030bc6c768838d65746010
  • Loading branch information
ltamasi authored and facebook-github-bot committed Oct 12, 2021
1 parent 22d4dc5 commit 7cc52cd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* Provided support for SingleDelete with user defined timestamp.
* Add remote compaction read/write bytes statistics: `REMOTE_COMPACT_READ_BYTES`, `REMOTE_COMPACT_WRITE_BYTES`.
* Introduce an experimental feature to dump out the blocks from block cache and insert them to the secondary cache to reduce the cache warmup time (e.g., used while migrating DB instance). More information are in `class CacheDumper` and `CacheDumpedLoader` at `rocksdb/utilities/cache_dump_load.h` Note that, this feature is subject to the potential change in the future, it is still experimental.
* Introduced a new BlobDB configuration option `blob_garbage_collection_force_threshold`, which can be used to trigger compactions targeting the SST files which reference the oldest blob files when the ratio of garbage in those blob files meets or exceeds the specified threshold. This can reduce space amplification with skewed workloads where the affected SST files might not otherwise get picked up for compaction.

### Public API change
* Made SystemClock extend the Customizable class and added a CreateFromString method. Implementations need to be registered with the ObjectRegistry and to implement a Name() method in order to be created via this method.
Expand Down
9 changes: 6 additions & 3 deletions db/version_set_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -483,9 +483,12 @@ TEST_F(VersionStorageInfoTest, ForcedBlobGCEmpty) {
}

TEST_F(VersionStorageInfoTest, ForcedBlobGC) {
// Add three L0 SSTs and four blob files. The first two SSTs keep alive the
// first two blob files, while the third SST keeps alive the third and fourth
// blob files.
// Add three L0 SSTs (1, 2, and 3) and four blob files (10, 11, 12, and 13).
// The first two SSTs have the same oldest blob file, namely, the very oldest
// one (10), while the third SST's oldest blob file reference points to the
// third blob file (12). Thus, the oldest batch of blob files contains the
// first two blob files 10 and 11, and assuming they are eligible for GC based
// on the age cutoff, compacting away the SSTs 1 and 2 will eliminate them.

constexpr int level = 0;

Expand Down

0 comments on commit 7cc52cd

Please sign in to comment.