Skip to content

Commit

Permalink
Bypass unused parameterization in ExternalSSTFileBasicTest.IngestExte… (
Browse files Browse the repository at this point in the history
#8910)

Summary:
Facebook infrastructure doesn't like continuously skipping
tests, so fixing this permanently disabled parameterization to BYPASS
instead of SKIP. (Internal ref: T100525285)

Pull Request resolved: #8910

Test Plan: manual

Reviewed By: anand1976

Differential Revision: D30905169

Pulled By: pdillinger

fbshipit-source-id: e23d63d2aa800e54676269fad3a093cd3f9f222d
  • Loading branch information
pdillinger authored and facebook-github-bot committed Sep 13, 2021
1 parent 306b779 commit 7bef598
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion db/external_sst_file_basic_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1524,7 +1524,11 @@ TEST_P(ExternalSSTFileBasicTest, IngestFileWithFirstByteTampered) {

TEST_P(ExternalSSTFileBasicTest, IngestExternalFileWithCorruptedPropsBlock) {
bool verify_checksums_before_ingest = std::get<1>(GetParam());
if (!verify_checksums_before_ingest || !random_rwfile_supported_) {
if (!verify_checksums_before_ingest) {
ROCKSDB_GTEST_BYPASS("Bypassing test when !verify_checksums_before_ingest");
return;
}
if (!random_rwfile_supported_) {
ROCKSDB_GTEST_SKIP("Test requires NewRandomRWFile support");
return;
}
Expand Down

0 comments on commit 7bef598

Please sign in to comment.