Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Do not include package-local polyfills. #1870

Closed
wants to merge 1 commit into from
Closed

RFC: Do not include package-local polyfills. #1870

wants to merge 1 commit into from

Commits on Jun 8, 2017

  1. RFC: Do not include package-local polyfills. 

    This removes babel's core-js polyfills from the distributed NPM builds. This aids in further reducing app bundle size when targeting modern browsers, and allows flexibility in how these polyfills are provided if necessary, which can help fix React Native specific issues, as illustrated in #1799 and #1704 and #1818.

The drawback is that polyfills for these things are now something that client developers will need to think about directly. Shipping Relay to older browsers before this diff should work fine, but after this diff will require global polyfills. As such, this diff may constitute at least a minor-breaking change.
    @leebyron
    leebyron committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    b372e30 View commit details
    Browse the repository at this point in the history