Update Changelog for v15.5.1-15.5.4 #9537

flarnie · 2017-04-27T02:43:33Z

This could really use extra code review attention since the history of
these changes was a bit convoluted to follow.

After talking to @bvaughn and @acdlite, we thought it might make sense
to put the 'add-ons' changes in a separate change log. The other option,
of including them in the main React change log, seemed the more
confusing of the two.

Also this commit is related to and somewhat blocked by
facebook/prop-types#40

Also - I will update the release tags after we land some version of a changelog.

what is the change?:
Adding the change log for recent patch versions of React.

why make this change?:
We missed this step in the flurry of releasing patches, and it's useful
for folks who want info about what version to use.

test plan:
Visual inspection of the change log.

issue:
#9443

@bvaughn

This could really use extra code review attention since the history of these changes was a bit convoluted to follow. After talking to @bvaughn and @acdlite, we thought it might make sense to put the 'add-ons' changes in a separate change log. The other option, of including them in the main React change log, seemed the more confusing of the two. Also this commit is related to and somewhat blocked by facebook/prop-types#40 **what is the change?:** Adding the change log for recent patch versions of React. **why make this change?:** We missed this step in the flurry of releasing patches, and it's useful for folks who want info about what version to use. **test plan:** Visual inspection of the change log. **issue:** facebook#9443

sophiebits · 2017-04-27T02:46:38Z

ADD-ONS-CHANGELOG.md

+
+## Pure Render Mixin
+
+### 15.5.2


Why is this one 15.5.2 and Test Utils has 15.5.1? (Can't tell if either is significant, honestly.)

I tried to figure out either what version a change was released in, or at least what the latest version of each package is. The latest version of each of these is 15.5.2 and 15.5.1 respectively.

bvaughn · 2017-04-27T03:06:38Z

ADD-ONS-CHANGELOG.md

+### 15.5.3
+
+* Fix react-addons-create-fragment package to export correct thing. [See #9383](https://github.com/facebook/react/pull/9383).
+* Envify and collapse create-fragment UMD. [See #9383](https://github.com/facebook/react/pull/9383).


This points to the same PR as above. Mistake?

Good of you to notice, and yes it's intentional. A bunch of these changes were made in PR 9383.

I think they were actually made in PR #9385 though, not PR #9383

You are right - thanks again for flagging!

bvaughn · 2017-04-27T03:09:13Z

ADD-ONS-CHANGELOG.md

+
+* Fix devDeps. [See #9383](https://github.com/facebook/react/pull/9383).
+* Add missing object-assign dependency. [See #9383](https://github.com/facebook/react/pull/9383).
+* Envify and collapse create-react-class UMD. [See #9383](https://github.com/facebook/react/pull/9383).


Actually these all point to the same PR

Think maybe you meant to link multiple bullets to PR #9385?

I can do that - also going to update this to use the '[@author] in [#PR/commit]' format.

gaearon · 2017-04-27T11:01:50Z

ADD-ONS-CHANGELOG.md

@@ -0,0 +1,59 @@
+# React Add-Ons Change Log


Do we want to have this file long term? Since these are final versions ever (hopefully), it seems a bit redundant to add a new file that we’ll never change, for parts that were technically discontinued. Maybe we could put this up as a gist instead?

Sounds good - will move it to a gist.

Maybe let’s just keep it in the main changelog? It seems like they could fit in fine if grouped under React Addons for each release (see like we did before).

Based on later comments, will move this inline to the main Changelog.

gaearon · 2017-04-27T11:36:16Z

ADD-ONS-CHANGELOG.md

+## Create Fragment
+
+### 15.5.3
+


In general we avoid deeply technical descriptions of changes.
I would prefer that instead of "envify and collapse" we would say something like

Fixed the accidental size regression in UMD bundles.

Aaah nice - that is a simpler way of saying it. Will fix.

gaearon · 2017-04-27T11:38:17Z

CHANGELOG.md

@@ -1,3 +1,21 @@
+## 15.5.4 (April 11, 2017)
+
+* Fix compatibility with Enzyme by exposing `batchedUpdates` on shallow renderer. [See #9382](https://github.com/facebook/react/commit/69933e25c37cf5453a9ef132177241203ee8d2fd).


Here, we try to separate React, React DOM, and React Test Renderer changes.
Can we make it clearer which package each change corresponds to?

I also think it might be simpler to roll addon updates right into this list, and summarize them as React Addons bullet point list for each version instead of giving each addon a section.

Sure - maybe that will be less confusing after all. Although then it's a bit tricky to map the add-on version to the React version. I guess I would annotate them in the section where React was using that version of the add-on.

Also will update all these to use the '[@author] in [#PR/commit]' format.

**what is the change?:** - Use the '[@author] in [#PR/commit]' format for annotations - Make annotations less technical, more clear - Move 'React Addons' updates into main changelog - Remove separate 'React Addons' changelog **why make this change?:** These changes each make things more clear and accurate. **test plan:** Visual inspection **issue:**

gaearon

Looks good (with nits)
Thanks!

gaearon · 2017-04-27T17:40:32Z

CHANGELOG.md

+
+### React Test Renderer
+
+* Fix compatibility with Enzyme by exposing `batchedUpdates` on shallow renderer. [See #9382](https://github.com/facebook/react/commit/69933e25c37cf5453a9ef132177241203ee8d2fd).


Assuming we'll fix up the link format here too to match others.

Thanks - missed that one. Will fix.

gaearon · 2017-04-27T17:43:17Z

CHANGELOG.md

+
+### React Addons
+
+* Fix react-addons-create-fragment package to export correct thing. ([@gaearon](https://github.com/gaearon) in [#9385](https://github.com/facebook/react/pull/9383))


Nit: lets use backticks for package names. We don't use them for proper names though (e.g. we either write React DOM or react-dom)

Ah - good to know. Fixing now. :)

@user

**what is the change?:** - Put backticks around package names - Reformat link to to commit in '([@user](...) in [#NNNN](...))' format - Remove newlines after subheaders; in the past we sometimes have included a newline after the subheader, but most recently it looks like we do not. - Add some missing punctuation. **why make this change?:** Consistency and aesthetics **test plan:** Visual inspection **issue:** facebook#9443

gaearon · 2017-04-28T17:20:26Z

CHANGELOG.md

+* Fix compatibility with Enzyme by exposing `batchedUpdates` on shallow renderer. ([@gaearon](https://github.com/gaearon) in [#9382](https://github.com/facebook/react/commit/69933e25c37cf5453a9ef132177241203ee8d2fd).
+
+
+## 15.5.3 (April 7, 2017)


AFAIK versions before 15.5.4 are using prop-types < 15.5.7 in the UMD, thus having the same critical issue. So we should make it clear all of them are effectively deprecated, and people should skip 15.5.0 to 15.5.3, and use at least 15.5.4.

Great - for now I'll add the same disclaimer from the 'prop-types' repo. Was also thinking of adding the 'yanked' annotation but since that would be a new convention will propose it in a follow-up PR.

**what is the change?:** Adding deprecation notice to some recent React versions. **why make this change?:** These versions of React use a version of `prop-types` that had a critical bug. We updated the dependency in React 15.5.4, and hopefully people will see this notice and update. **test plan:** Visual inspection **issue:** facebook#9537

flarnie requested review from bvaughn, gaearon and acdlite April 27, 2017 02:43

facebook-github-bot added the CLA Signed label Apr 27, 2017

sophiebits reviewed Apr 27, 2017

View reviewed changes

bvaughn suggested changes Apr 27, 2017

View reviewed changes

gaearon reviewed Apr 27, 2017

View reviewed changes

flarnie mentioned this pull request Apr 27, 2017

Add 'Unreleased' section to changelog; update 'contributing' docs #9532

Closed

gaearon approved these changes Apr 27, 2017

View reviewed changes

gaearon reviewed Apr 28, 2017

View reviewed changes

flarnie merged commit 0549c45 into facebook:master May 1, 2017

flarnie deleted the updateChangelogFor15patches branch May 25, 2018 17:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Changelog for v15.5.1-15.5.4 #9537

Update Changelog for v15.5.1-15.5.4 #9537

flarnie commented Apr 27, 2017 •

edited

Loading

sophiebits Apr 27, 2017

flarnie Apr 27, 2017

bvaughn Apr 27, 2017

flarnie Apr 27, 2017

bvaughn Apr 27, 2017

flarnie Apr 27, 2017

bvaughn Apr 27, 2017

bvaughn Apr 27, 2017

flarnie Apr 27, 2017

gaearon Apr 27, 2017

flarnie Apr 27, 2017

gaearon Apr 27, 2017

flarnie Apr 27, 2017

gaearon Apr 27, 2017

flarnie Apr 27, 2017

gaearon Apr 27, 2017

flarnie Apr 27, 2017

flarnie Apr 27, 2017

gaearon left a comment

gaearon Apr 27, 2017

flarnie Apr 28, 2017

gaearon Apr 27, 2017

flarnie Apr 28, 2017

gaearon Apr 28, 2017

flarnie May 1, 2017

		@@ -1,3 +1,21 @@
		## 15.5.4 (April 11, 2017)

		* Fix compatibility with Enzyme by exposing `batchedUpdates` on shallow renderer. [See #9382](https://github.com/facebook/react/commit/69933e25c37cf5453a9ef132177241203ee8d2fd).


		### React Test Renderer

		* Fix compatibility with Enzyme by exposing `batchedUpdates` on shallow renderer. [See #9382](https://github.com/facebook/react/commit/69933e25c37cf5453a9ef132177241203ee8d2fd).


		### React Addons

		* Fix react-addons-create-fragment package to export correct thing. ([@gaearon](https://github.com/gaearon) in [#9385](https://github.com/facebook/react/pull/9383))

		* Fix compatibility with Enzyme by exposing `batchedUpdates` on shallow renderer. ([@gaearon](https://github.com/gaearon) in [#9382](https://github.com/facebook/react/commit/69933e25c37cf5453a9ef132177241203ee8d2fd).


		## 15.5.3 (April 7, 2017)

Update Changelog for v15.5.1-15.5.4 #9537

Update Changelog for v15.5.1-15.5.4 #9537

Conversation

flarnie commented Apr 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaearon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flarnie commented Apr 27, 2017 •

edited

Loading