WIP - convert public React core properties to strings so uglify/gcc can mangle #9293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an exclude them from being mangled
|
You're missing the base class and the updater. That might set you back a bit. |
|
Does this mean we need to change every single native method call? Ex: .map(), .indexOf(), etc. |
|
@spicyj No, we shouldn't have to. They should all be natively supported. Well, they definitely are in gcc. |
simonkberg
reviewed
Apr 28, 2017
| var REACT_ELEMENT_TYPE = (typeof Symbol === 'function' && | ||
| Symbol.for && | ||
| Symbol.for('react.element')) || | ||
| const SymbolFor = Symbol.for; |
There was a problem hiding this comment.
This will throw in environments without Symbol
|
Tracking in #11092. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, we want to be able to leverage stronger minifcations/optimizations in our tooling so we can provide even smaller bundles. Tools such as Uglify and Google Closure Compiler can do this when set to mangle internal properties. However, this can break things when properties are expected to be consumed in the wild/public or by contract from another module.
The simplest way to deal with this limitation is to manually specify that the property shouldn't be altered when it's a string literal. Whitelisting is also an option, however that has some limitations and can result in properties that aren't public not being mangled simply because of them being a common name.
This PR is a WIP.