Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary indirection and events from the hooks #7464

Merged
merged 3 commits into from
Aug 10, 2016
Merged

Remove unnecessary indirection and events from the hooks #7464

merged 3 commits into from
Aug 10, 2016

Commits on Aug 10, 2016

  1. Remove unnecessary indirection from the tree hook

    @gaearon
    gaearon committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    af0c831 View commit details
    Browse the repository at this point in the history

  2. Replace onSetDisplayName, onSetOwner, onSetText with one event 

    Less events is better.
onSetDisplayName, onSetOwner, and onSetText only existed because we didn't initially track elements.
    @gaearon
    gaearon committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    f448285 View commit details
    Browse the repository at this point in the history

  3. Remove unused variables

    @gaearon
    gaearon committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    2489f8f View commit details
    Browse the repository at this point in the history