Upgrade Flow #6957
Merged
Upgrade Flow #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
👍 |
Also ignore examples, important because react can be installed by the commonjs one and the modules will get detected there too, resulting in duplicate definitions
|
Fixed the rest of it too and just combined with other |
| @@ -394,9 +394,9 @@ function diffProperties( | |||
| // default: fallthrough case when nested properties are defined | |||
| removedKeys = null; | |||
| removedKeyCount = 0; | |||
| // $FlowFixMe - We think that attributeConfig is not | |||
| // CustomAttributeConfiguration at this point so we assume | |||
| // it must be AttributeConfiguration. | |||
There was a problem hiding this comment.
@gabelevi - Not sure if you or somebody else would want to make this multi-line format work. I would have expected this to work but apparently it doesn't just apply it to the next real code line and presumably just applies it to the next line which in this case was a comment.
|
@zpao updated the pull request. |
zpao
added a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
Upgrade Flow (cherry picked from commit d3b36d5)
zpao
added a commit
that referenced
this pull request
Jun 14, 2016
Upgrade Flow (cherry picked from commit d3b36d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of this was done in a codemod by @bhosmer.
Since we aren't syncing all the RN stuff in, there are more failures there unrelated to ReactElement but for other reasons. We should clean those up too since flow should actually be failing right now.