Batch event handling in React Native #6572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where handling events on a node that was just removed threw a "All native instances should have a tag." error and matches what we do in the DOM renderer in ReactEventListener.
sophiebits
added a commit
that referenced
this pull request
Apr 21, 2016
Batch event handling in React Native
ghost
pushed a commit
to facebook/react-native
that referenced
this pull request
May 16, 2016
Summary: A React pull request broke the Picker: facebook/react#6572 This pull request adds a test so that we prevent breakages like this in the future. `PickerAndroidExample` in the UIExplorer before the breakage (video): https://vid.me/h5Rg `PickerAndroidExample` in the UIExplorer after the breakage (video): https://vid.me/atFc **Test plan** `./scripts/run-android-local-integration-test.sh` The test is failing, we can only merge this once React is fixed. <img width="837" alt="screen shot 2016-05-04 at 5 13 31 pm" src="https://cloud.githubusercontent.com/assets/346214/15020827/aca8d718-121b-11e6-91f6-a338293d7d92.png"> Closes #7390 Differential Revision: D3305223 Pulled By: mkonicek fbshipit-source-id: 89137812940c578efff3e76864ab7cadccc9f2ea
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary: A React pull request broke the Picker: facebook/react#6572 This pull request adds a test so that we prevent breakages like this in the future. `PickerAndroidExample` in the UIExplorer before the breakage (video): https://vid.me/h5Rg `PickerAndroidExample` in the UIExplorer after the breakage (video): https://vid.me/atFc **Test plan** `./scripts/run-android-local-integration-test.sh` The test is failing, we can only merge this once React is fixed. <img width="837" alt="screen shot 2016-05-04 at 5 13 31 pm" src="https://cloud.githubusercontent.com/assets/346214/15020827/aca8d718-121b-11e6-91f6-a338293d7d92.png"> Closes facebook#7390 Differential Revision: D3305223 Pulled By: mkonicek fbshipit-source-id: 89137812940c578efff3e76864ab7cadccc9f2ea
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: A React pull request broke the Picker: facebook/react#6572 This pull request adds a test so that we prevent breakages like this in the future. `PickerAndroidExample` in the UIExplorer before the breakage (video): https://vid.me/h5Rg `PickerAndroidExample` in the UIExplorer after the breakage (video): https://vid.me/atFc **Test plan** `./scripts/run-android-local-integration-test.sh` The test is failing, we can only merge this once React is fixed. <img width="837" alt="screen shot 2016-05-04 at 5 13 31 pm" src="https://cloud.githubusercontent.com/assets/346214/15020827/aca8d718-121b-11e6-91f6-a338293d7d92.png"> Closes facebook#7390 Differential Revision: D3305223 Pulled By: mkonicek fbshipit-source-id: 89137812940c578efff3e76864ab7cadccc9f2ea
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: A React pull request broke the Picker: facebook/react#6572 This pull request adds a test so that we prevent breakages like this in the future. `PickerAndroidExample` in the UIExplorer before the breakage (video): https://vid.me/h5Rg `PickerAndroidExample` in the UIExplorer after the breakage (video): https://vid.me/atFc **Test plan** `./scripts/run-android-local-integration-test.sh` The test is failing, we can only merge this once React is fixed. <img width="837" alt="screen shot 2016-05-04 at 5 13 31 pm" src="https://cloud.githubusercontent.com/assets/346214/15020827/aca8d718-121b-11e6-91f6-a338293d7d92.png"> Closes facebook#7390 Differential Revision: D3305223 Pulled By: mkonicek fbshipit-source-id: 89137812940c578efff3e76864ab7cadccc9f2ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where handling events on a node that was just removed threw a "All native instances should have a tag." error and matches what we do in the DOM renderer in ReactEventListener.