Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep reference equality if possible in update() #6353

Closed
wants to merge 7 commits into from
Closed

Keep reference equality if possible in update() #6353

wants to merge 7 commits into from

Commits on Sep 26, 2015

  1. Keep reference equality when possible in update() 

    For $set and $apply it is cheap and easy to check whether the new value will
be identical (===) to the old value and create a new object only when this is not
the case. This will reduce excessive renders when using the pureRenderMixin.

The same should be possible for for merge, but is more complicated so is not
attempted here.
    @davidmason
    davidmason committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    b08b45d View commit details
    Browse the repository at this point in the history

  2. Add tests for reference equality in update()

    @davidmason
    davidmason committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    8bc8e58 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2016

  1. Merge remote-tracking branch 'davidmason/master' into update

    @gaearon
    gaearon committed Mar 26, 2016
    Configuration menu
    Copy the full SHA
    fbc1352 View commit details
    Browse the repository at this point in the history

  2. Group update() tests

    @gaearon
    gaearon committed Mar 26, 2016
    Configuration menu
    Copy the full SHA
    0d6b84e View commit details
    Browse the repository at this point in the history

  3. Add more tests for preserving identity on deep update()s

    @gaearon
    gaearon committed Mar 26, 2016
    Configuration menu
    Copy the full SHA
    7be3696 View commit details
    Browse the repository at this point in the history

  4. Refactor update() referential equality code to avoid fn allocations

    @gaearon
    gaearon committed Mar 26, 2016
    Configuration menu
    Copy the full SHA
    644c102 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2016

  1. Remove unnecessary equality check

    @gaearon
    gaearon committed Mar 27, 2016
    Configuration menu
    Copy the full SHA
    b970022 View commit details
    Browse the repository at this point in the history