add prs welcome badge #6333
add prs welcome badge #6333
Conversation
| @@ -1,4 +1,4 @@ | |||
| # [React](https://facebook.github.io/react/) [](https://travis-ci.org/facebook/react) [](https://coveralls.io/github/facebook/react?branch=master) [](https://www.npmjs.com/package/react) | |||
| # [React](https://facebook.github.io/react/) [](https://travis-ci.org/facebook/react) [](https://coveralls.io/github/facebook/react?branch=master) [](https://www.npmjs.com/package/react) [](http://makeapullrequest.com) | |||
There was a problem hiding this comment.
As mentioned in the other PR, I don't feel quite comfortable with that link / lesson plan, for reasons mentioned here: #6332 (comment)
The badge its self (unlinked) could be ok. Or we could link it to a gist that describes the React-specific notes about how we manage pull requests.
There was a problem hiding this comment.
I'd be cool with the badge linking to react-specific notes. I'm mostly motivated by a desire to make it easier for beginners to contribute to React.
There was a problem hiding this comment.
I'd be fine with this if we link it to https://github.com/facebook/react/blob/master/CONTRIBUTING.md for now. We can find a different/better destination later.
kentcdodds
force-pushed
the
pr/beginner-friendly-badge
branch
from
63ae22d
to
6b307a5
Compare
|
It now links to the |
|
@kentcdodds updated the pull request. |
| @@ -1,4 +1,4 @@ | |||
| # [React](https://facebook.github.io/react/) [](https://travis-ci.org/facebook/react) [](https://coveralls.io/github/facebook/react?branch=master) [](https://www.npmjs.com/package/react) | |||
| # [React](https://facebook.github.io/react/) [](https://travis-ci.org/facebook/react) [](https://coveralls.io/github/facebook/react?branch=master) [](https://www.npmjs.com/package/react) [](CONTRIBUTING.md#pull-requests) | |||
There was a problem hiding this comment.
Should be the full path to the page: https://github.com/facebook/react/blob/master/CONTRIBUTING.md#pull-requests
There was a problem hiding this comment.
¯\_(ツ)_/¯ works fine either way. Test it here. Nice thing about this is that it'll work in forks as well. But let me know if you want me to change it.
There was a problem hiding this comment.
It's fine. The reason it broke in a changelog is because it was copied to the docs.
|
Thanks @kentcdodds! |
|
Fantastic! |
As referenced in #6332, this adds the
PRs | Welcomebadge to the README which links to a free beginner friendly resource teaching how to get started contributing to open source.Here's before:
Here's after:
Happy to make any changes. Just want to get the conversation going.