Fix build for useCreateElement: false, run Travis #6070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
force-pushed
the
server-text
branch
from
12f3ea5
to
5516677
Compare
|
@spicyj updated the pull request. |
sophiebits
force-pushed
the
server-text
branch
from
5516677
to
cab7444
Compare
|
@spicyj updated the pull request. |
sophiebits
force-pushed
the
server-text
branch
from
cab7444
to
6326289
Compare
|
@spicyj updated the pull request. |
|
yay travis passes |
| @@ -149,13 +150,29 @@ assign(ReactDOMTextComponent.prototype, { | |||
| if (nativeNode) { | |||
| return nativeNode; | |||
| } | |||
| nativeNode = [this._openingComment, this._nativeNode]; | |||
| if (!this._closingComment) { | |||
There was a problem hiding this comment.
Woops, sorry, I guess I assumed useCreateElement=false was already tested. But this seems obvious now. Too bad we needed the code to find the other comment, after all.
There was a problem hiding this comment.
Yeah, I forgot about it too. Ah well.
| @@ -73,6 +73,11 @@ script: | |||
| else | |||
| ./node_modules/.bin/grunt jest:normal | |||
| fi | |||
| echo 'Testing in server-render (HTML generation) mode...' | |||
| printf '\nmodule.exports.useCreateElement = false;\n' \ | |||
There was a problem hiding this comment.
I personally would have used echo for this too but meh.
Otherwise it seems good.
There was a problem hiding this comment.
I don't think you can escape stuff (newlines) inside echo reliably cross-platform.
These weren't caught by CI in facebook#5753 because we don't automatically test that yet... fixing that next.
It's important that we keep these code paths working because they're the only comprehensive test of adopting server-rendered HTML that we have right now. This is terrible and hacky but I am hopeful that it will at least catch stuff.
sophiebits
force-pushed
the
server-text
branch
from
6326289
to
81e5dd0
Compare
sophiebits
added a commit
that referenced
this pull request
Feb 19, 2016
Fix build for useCreateElement: false, run Travis
|
@spicyj updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important that we keep these code paths working because they're the only comprehensive test of adopting server-rendered HTML that we have right now. This is terrible and hacky but I am hopeful that it will at least catch stuff.
cc @mwiencek for text changes (I missed these in #5753), @zpao for clowny Travis stuff I added here